xiaoxiang781216 edited a comment on pull request #3517: URL: https://github.com/apache/incubator-nuttx/pull/3517#issuecomment-817957982
> > Please reread my reply in the previous thread. > > So this is just a redesign of working code with no value added. It is just for your personal preference. That is not in the spirit of a good open source project. It is bad to humiliate people by throwing away there perfectly good code just so you can replace with your own NIH code. Very bad style. > No, it isn't just preference, here is the reason I made this change: 1. Unify the memory allocation from stack with up_stack_frame regardless it's TLS data or argv. 2. Avoid skip TLS space explicitly in many place since TLS is allocated(remove from picture) like other stack variable 3. Don't need save tg_libvars pointer in task_group_s and tls_info_s The most important thing is that ``Modular Architecture```get improved because almost TLS special handling is decoupled and removed from arch, the benefit include: 1. Avoid the code duplication in each arch(reduce 600+ line 31.7%) 2. Fix #1631 in the common place(sched/) and avoid the similar problem happen again in new arch > Okay. I will wait until you separate this into reviewable PRs. It is impossible to properly review this big mess. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
