xiaoxiang781216 commented on pull request #3517: URL: https://github.com/apache/incubator-nuttx/pull/3517#issuecomment-818393928
> > I get the gist of it mostly > > Same with me. There is just too much unrelated stuff crammed into the same PR. It is not humanly possible to review properly. It was worse originally... there was only one commit with everything in it. We need to try avoid PRs like this in future if we want proper reviews. Yes, I also want to split the patch into small one as I do normally. But since the change in up_stack_frame(allocate from the low end of stack) impact many thing: 1. Stack check and dump 2. TLS data allocation 3. vfork stack duplication It's more simple to only focus on arm arch, since the same change duplicate in each arch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
