yamt opened a new pull request #3574:
URL: https://github.com/apache/incubator-nuttx/pull/3574


   ## Summary
   
   Reapply the following commit [1], which has been reverted by
   the recent change [2] with no obvious reasons.
   
   Also, add a comment block to explain the calculation.
   
   [1]
   ```
   commit 298c2e5e4fb46f5ffa7de7bbc5a32a9da0663768
   Author: YAMAMOTO Takashi <yamam...@midokura.com>
   Date:   Wed Jan 29 03:26:43 2020 +0900
   
       sim: Fix stack alignment
   
       The recent x86-64 convention requires 16-byte alignment before
       (not after) calling a function.
   
       This fixes snprintf crash I observed on macOS while saving XMM registers.
   ```
   
   [2]
   ```
   commit 2335b69120a3e36f1aa0cecc19c95208806cae54
   Author: Xiang Xiao <xiaoxi...@xiaomi.com>
   Date:   Mon Apr 12 23:44:08 2021 +0800
   
       arch: Allocate the space from the beginning in up_stack_frame
   
       arch: Allocate the space from the beginning in up_stack_frame
   
       and modify the affected portion:
       1.Correct the stack dump and check
       2.Allocate tls_info_s by up_stack_frame too
       3.Move the stack fork allocation from arch to sched
   
       Signed-off-by: Xiang Xiao <xiaoxi...@xiaomi.com>
   ```
   
   ## Impact
   
   ## Testing
   
   sim:ostest on macOS
   (I stopped it in the middle of it because i had no time to run it to the end.
   I guess it's enough testing because It was crashing immediately before this 
change.)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to