v01d commented on pull request #3589:
URL: https://github.com/apache/incubator-nuttx/pull/3589#issuecomment-825191064
> > @antmerlino @davids5 what are your though on the integration of NuttX
with CMake as part of a larger project? Would the top-level project simply use
ExternalProject to nest NuttX build system? I'm also thinking about current
"export" feature of Make-based system. Do we still need this?
>
> I think we should take it slow to not force the migration on our users
base all at once.
You're right. I will look into adding an export target.
> But ultimately NuttX can be a library. We should allow the consuming
project to be able to configure build options. Things like `-Werror` etc. There
are also some compile time settings that need to be equivalent in both builds.
Like `CONFIG_ARMV7M_STACKCHECK` -> drives `FLAGS += -finstrument-functions
-ffixed-r10` [see this for
example](https://github.com/PX4/PX4-Autopilot/blob/437825418297c1ff43681acc6cf870e2f51d1dcb/platforms/nuttx/NuttX/Make.defs.in#L120)
I'm not sure what specific things to have in mind to achieve this. But I
guess we can leave it for later on once things are more settled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
