davids5 commented on a change in pull request #3618:
URL: https://github.com/apache/incubator-nuttx/pull/3618#discussion_r622175784
##########
File path: arch/arm/src/stm32h7/stm32_serial.c
##########
@@ -3375,10 +3375,7 @@ static void up_dma_txavailable(struct uart_dev_s *dev)
/* Only send when the DMA is idle */
- if (resid != 0)
Review comment:
I think this is the wrong approach. We have to wait if there is a
residual.
Having an initial count of 1 means the first time, the DMA can be active and
we ignore it.
I think the correct approach it the DMA completion should check the count
and only post if the semaphore is being waited on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
