patacongo commented on issue #3799:
URL:
https://github.com/apache/incubator-nuttx/issues/3799#issuecomment-850835771
> > Could you add the quotes and see if that fixes it?
>
> Yes, but that will have to be tomorrow morning.
Unfortunately, that does not fix the problem. Here is the change I made:
diff --git a/tools/Config.mk b/tools/Config.mk
index 6adbebf21a..23a1acc1c2 100644
--- a/tools/Config.mk
+++ b/tools/Config.mk
@@ -182,19 +182,19 @@ endif
OBJPATH ?= .
%.dds: %.S
- $(Q) $(MKDEP) --obj-path $(OBJPATH) --obj-suffix $(OBJEXT)
$(DEPPATH) "$(CC)" -- $(CFLAGS) -- $< > $@
+ $(Q) $(MKDEP) --obj-path $(OBJPATH) --obj-suffix $(OBJEXT)
$(DEPPATH) "$(CC)" -- "$(CFLAGS)" -- $< > $@
%.ddc: %.c
- $(Q) $(MKDEP) --obj-path $(OBJPATH) --obj-suffix $(OBJEXT)
$(DEPPATH) "$(CC)" -- $(CFLAGS) -- $< > $@
+ $(Q) $(MKDEP) --obj-path $(OBJPATH) --obj-suffix $(OBJEXT)
$(DEPPATH) "$(CC)" -- "$(CFLAGS)" -- $< > $@
%.ddp: %.cpp
- $(Q) $(MKDEP) --obj-path $(OBJPATH) --obj-suffix $(OBJEXT)
$(DEPPATH) "$(CXX)" -- $(CXXFLAGS) -- $< > $@
+ $(Q) $(MKDEP) --obj-path $(OBJPATH) --obj-suffix $(OBJEXT)
$(DEPPATH) "$(CXX)" -- "$(CXXFLAGS)" -- $< > $@
%.ddx: %.cxx
- $(Q) $(MKDEP) --obj-path $(OBJPATH) --obj-suffix $(OBJEXT)
$(DEPPATH) "$(CXX)" -- $(CXXFLAGS) -- $< > $@
+ $(Q) $(MKDEP) --obj-path $(OBJPATH) --obj-suffix $(OBJEXT)
$(DEPPATH) "$(CXX)" -- "$(CXXFLAGS)" -- $< > $@
%.ddh: %.c
- $(Q) $(MKDEP) --obj-path $(OBJPATH) --obj-suffix $(OBJEXT)
$(DEPPATH) "$(CC)" -- $(HOSTCFLAGS) -- $< > $@
+ $(Q) $(MKDEP) --obj-path $(OBJPATH) --obj-suffix $(OBJEXT)
$(DEPPATH) "$(CC)" -- "$(HOSTCFLAGS)" -- $< > $@
# INCDIR - Convert a list of directory paths to a list of compiler
include
# directories
@@ -258,7 +258,7 @@ endef
define COMPILE
@echo "CC: $1"
- $(Q) $(CC) -c $(CFLAGS) $($(strip $1)_CFLAGS) $1 -o $2
+ $(Q) $(CC) -c "$(CFLAGS)" $($(strip $1)_CFLAGS) $1 -o $2
endef
# COMPILEXX - Default macro to compile one C++ file
@@ -276,7 +276,7 @@ endef
define COMPILEXX
@echo "CXX: $1"
- $(Q) $(CXX) -c $(CXXFLAGS) $($(strip $1)_CXXFLAGS) $1 -o $2
+ $(Q) $(CXX) -c "$(CXXFLAGS)" $($(strip $1)_CXXFLAGS) $1 -o $2
endef
# ASSEMBLE - Default macro to assemble one assembly language file
And here is the result:
$ make staging/libc.a
...
make[1]: Entering directory
'/cygdrive/d/Spuda/Documents/projects/nuttx/master/nuttx_fork/libs/libc'
make[2]: Entering directory
'/cygdrive/d/Spuda/Documents/projects/nuttx/master/nuttx_fork/libs/libc'
.\dirent/lib_readdirr.c:25:10: fatal error: nuttx/config.h: No such file
or directory
25 | #include <nuttx/config.h>
| ^~~~~~~~~~~~~~~~
compilation terminated.
ERROR: arm-none-eabi-gcc failed: 1
command: arm-none-eabi-gcc -MT bin\\lib_readdirr.o -M
'-fno-builtin' '-funwind-tables' '-Wall' '-Wstrict-prototypes' '-Wshadow'
'-Wundef' '-Os' '-fno-strict-aliasing' '-fomit-frame-pointer'
'-fno-strength-reduce' '-mcpu=cortex-m4' '-mthumb' '-mfloat-abi=soft'
'-isystem' 'D:SpudaDocumentsprojectsnuttxmasternuttx_forkinclude' '-D__NuttX__'
'-pipe' '-I' 'D:SpudaDocumentsprojectsnuttxmasternuttx_forklibslibc'
.\\dirent/lib_readdirr.c
make[2]: ***
[/cygdrive/d/Spuda/Documents/projects/nuttx/master/nuttx_fork/tools/Config.mk:188:
lib_readdirr.ddc] Error 1
make[2]: Leaving directory
'/cygdrive/d/Spuda/Documents/projects/nuttx/master/nuttx_fork/libs/libc'
make[1]: *** [Makefile:169: .depend] Error 2
make[1]: Leaving directory
'/cygdrive/d/Spuda/Documents/projects/nuttx/master/nuttx_fork/libs/libc'
make: *** [tools/Makefile.unix:468: pass1dep] Error 2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
