xiaoxiang781216 commented on a change in pull request #3807:
URL: https://github.com/apache/incubator-nuttx/pull/3807#discussion_r642490813
##########
File path: drivers/syslog/Kconfig
##########
@@ -215,20 +211,21 @@ config SYSLOG_RPMSG
---help---
Use the rpmsg as a SYSLOG output device, send message to remote
proc.
-config SYSLOG_RPMSG_SERVER_NAME
- string "The name of Syslog Rpmsg Server"
- depends on SYSLOG_RPMSG
- ---help---
- The proc name of rpmsg server. Client sends message to
- specified name of remote proc.
-
config SYSLOG_DEFAULT
bool "Default SYSLOG device"
+ default ARCH_LOWPUTC && !SYSLOG_RPMSG && !SYSLOG_CONSOLE &&
!RAMLOG_SYSLOG && !SYSLOG_CHAR
---help---
syslog() interfaces will be present, but all output will go to
the
up_putc(ARCH_LOWPUTC == y) or bit-bucket(ARCH_LOWPUTC == n).
-endchoice
+endif
+
+config SYSLOG_RPMSG_SERVER_NAME
+ string "The name of Syslog Rpmsg Server"
+ depends on SYSLOG_RPMSG
Review comment:
There isn't a suitable default value, so it's better to no default value
at all and then enforce the user must give one in defconfig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
