xiaoxiang781216 commented on a change in pull request #3809:
URL: https://github.com/apache/incubator-nuttx/pull/3809#discussion_r644445001
##########
File path: drivers/spi/spi_slave_driver.c
##########
@@ -57,7 +57,7 @@
* Private Types
****************************************************************************/
-struct spislv_driver_s
+struct spislave_driver_s
Review comment:
Here is the convention used by i2c slave:
i2c_slave_s/i2c_slaveops_s/I2CS_XXX
How about we use the similar convention for spi slave:
spi_slave_dev_s/spi_slave_devops_s/spi_slave_ctrlr_s/spi_slave_ctrlrops_s/SPIS_DEV_XXX/SPIS_CTRLR_XXX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
