hartmannathan commented on pull request #3862: URL: https://github.com/apache/incubator-nuttx/pull/3862#issuecomment-855544255
> On 6/6/2021 5:34 PM, hartmannathan wrote: There is one more missing License text that John pointed out in the above-referenced VOTE email: that of additional logic by Steve Reynolds for IGMP. I don't know where to get that license text from. Do you happen to have a copy in the code you originally pulled? (Or know where to find it?) I am not sure where Steve Reynold's IGMP came from. I can't find the original files that I worked with. But I see that it is also a part of lwip: https://github.com/pycom/esp-idf-2.0/blob/master/components/lwip/core/ipv4/igmp.c <https://github.com/pycom/esp-idf-2.0/blob/master/components/lwip/core/ipv4/igmp.c> But I don't recall ever using anything from lwip, but maybe that is where it came from originally? It is very different from the highly modified IGMP in NuttX. Hmm, this will take a bit more research. I'll see what I can come up with... > I think that is the file. In the LICENSE file, it has: GMP ==== IGMP support, if enabled, adds additional logic by Steve Reynolds: Copyright (c) 2002 CITEL Technologies Ltd. All rights reserved. And that lwip reference has: /* * Copyright (c) 2002 CITEL Technologies Ltd. * All rights reserved. * So I think we have it covered. The file you pointed out (there's an lwIP mirror at [https://github.com/lwip-tcpip/lwip/blob/master/src/core/ipv4/igmp.c](https://github.com/lwip-tcpip/lwip/blob/master/src/core/ipv4/igmp.c) which has the same file) has this BSD-style license text in its header: ``` /* * Copyright (c) 2002 CITEL Technologies Ltd. * All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions * are met: * 1. Redistributions of source code must retain the above copyright * notice, this list of conditions and the following disclaimer. * 2. Redistributions in binary form must reproduce the above copyright * notice, this list of conditions and the following disclaimer in the * documentation and/or other materials provided with the distribution. * 3. Neither the name of CITEL Technologies Ltd nor the names of its contributors * may be used to endorse or promote products derived from this software * without specific prior written permission. * * THIS SOFTWARE IS PROVIDED BY CITEL TECHNOLOGIES AND CONTRIBUTORS ``AS IS'' * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE * ARE DISCLAIMED. IN NO EVENT SHALL CITEL TECHNOLOGIES OR CONTRIBUTORS BE LIABLE * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * * This file is a contribution to the lwIP TCP/IP stack. * The Swedish Institute of Computer Science and Adam Dunkels * are specifically granted permission to redistribute this * source code. */ ``` If our IGMP code originally derived from that lwIP file, then I think the above BSD-style license should be placed in our top-level LICENSE file, where we currently have only the first two lines. I wonder whether we are supposed to include those last four lines, which are granting specific permission to Adam Dunkels and the Swedish Institute of Computer Science. IANAL but doesn't the BSD-style license directly above it grant permission to anyone to redistribute in source and binary forms? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
