donghengqaz commented on pull request #3757: URL: https://github.com/apache/incubator-nuttx/pull/3757#issuecomment-855623646
> > @acassis @xiaoxiang781216 I think functions like save/restore interrupt are arch level functions, so we may not put implementation into each chip under this arch, and we should put these functions in arch common header file, besides this these function should be `inline` for better performance. > > But some chips may be not able to use these functions, they use their private functions to save/restore interrupt, so I add this macro to let chips to select use arch common one to itself's private function. > > How to enable/disable irq is defined by RISC-V spec, it suppose one implementation should work for all RISC-V chipset. Since other arch share the same implementation, we can do the same thing for RISC-V now until we find the chipset which need specially handling. OK, do you think it is OK for me to remove these functions from each risc-v chip's IRQ driver and implement them in risc-v common IRQ header file ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
