xiaoxiang781216 commented on a change in pull request #3869:
URL: https://github.com/apache/incubator-nuttx/pull/3869#discussion_r647933286
##########
File path: drivers/syslog/syslog_filechannel.c
##########
@@ -60,6 +60,23 @@ FAR static struct syslog_channel_s *g_syslog_file_channel;
* Private Functions
****************************************************************************/
+#ifdef CONFIG_SYSLOG_FILE_SEPARATE
+static void log_separate(FAR const char *log_file)
+{
+ int fd;
+
+ fd = open(log_file, O_WRONLY);
Review comment:
Yes, the prefer is file_open->nx_open->open inside kernel space. Kernel
space perfer file_xxx, but since not all fs function has the kernel version, we
have to fallback to nx_ or userspace version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
