lulingar commented on a change in pull request #3836:
URL: https://github.com/apache/incubator-nuttx/pull/3836#discussion_r649190581
##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -83,7 +83,7 @@ endif
CC = $(CROSSDEV)cc
CXX = $(CROSSDEV)c++
CPP = $(CROSSDEV)cc -E -P -x c
-LD = $(CROSSDEV)ld
+LD = $(CROSSDEV)gcc
Review comment:
This is breaking our clang-based build. Our build fails like:
echo "LD: nuttx"
LD: nuttx
gcc -r -L"/nuttx/staging" -L board -o nuttx.rel up_head.o
-Wl,--start-group -lsched -ldrivers -lboards -lc -lmm -larch -lapps -lnet -lfs
-lbinfmt -lboard -Wl,--end-group
/bin/sh: 1: gcc: not found
make[1]: Leaving directory '/nuttx/arch/sim/src'
make[1]: *** [Makefile:314: nuttx] Error 127
make: *** [tools/Makefile.unix:422: nuttx] Error 2
The command '/bin/sh -c bear -v make -j $(grep -c ^processor
/proc/cpuinfo) V=2' returned a non-zero code: 2
make: *** [process/Build.mk:39: builder] Error
Previously it was:
ld -r -L"/nuttx/staging" -L board -o nuttx.rel up_head.o --start-group
-lsched -ldrivers -lboards -lc -lmm -larch -lapps -lnet -lfs -lbinfmt -lboard
--end-group
Certainly I agree with the suggestion this change should have been widely
advertised before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
