Ouss4 commented on a change in pull request #3946:
URL: https://github.com/apache/incubator-nuttx/pull/3946#discussion_r654260062
##########
File path: arch/xtensa/src/esp32s2/Make.defs
##########
@@ -79,8 +79,3 @@ ifeq ($(CONFIG_ESP32S2_UART),y)
CMN_CSRCS += esp32s2_serial.c
endif
-ifeq ($(CONFIG_ARCH_USE_MODULE_TEXT),y)
-CHIP_CSRCS += esp32s2_modtext.c
-CMN_ASRCS += xtensa_loadstore.S
-endif
Review comment:
yeah... I'm about to delete it.. I just didn't want to spend time on it.
This was a copy past from the ESP32 port that shouldn't even be here.
ESP32-S2 memory model is similar to ESP32-C3 not ESP32. We don't have a
separate region accessed only by I-Bus. So its (now non-existent) text
allocator would just allocate from the main heap and adjust the buffer to be
accessed from I-Bus. I didn't do this for ESP32-S2 because the port is new. I
want to wait until we have more into it.
##########
File path: arch/xtensa/src/esp32s2/Make.defs
##########
@@ -79,8 +79,3 @@ ifeq ($(CONFIG_ESP32S2_UART),y)
CMN_CSRCS += esp32s2_serial.c
endif
-ifeq ($(CONFIG_ARCH_USE_MODULE_TEXT),y)
-CHIP_CSRCS += esp32s2_modtext.c
-CMN_ASRCS += xtensa_loadstore.S
-endif
Review comment:
> I'm about to delete it..
This was in reference to the `esp32s2_user.c` part.
##########
File path: arch/xtensa/src/esp32s2/Make.defs
##########
@@ -79,8 +79,3 @@ ifeq ($(CONFIG_ESP32S2_UART),y)
CMN_CSRCS += esp32s2_serial.c
endif
-ifeq ($(CONFIG_ARCH_USE_MODULE_TEXT),y)
-CHIP_CSRCS += esp32s2_modtext.c
-CMN_ASRCS += xtensa_loadstore.S
-endif
Review comment:
yeah, I'm about to delete it.. I just didn't want to spend time on it.
This was a copy past from the ESP32 port that shouldn't even be here.
ESP32-S2 memory model is similar to ESP32-C3 not ESP32. We don't have a
separate region accessed only by I-Bus. So its (now non-existent) text
allocator would just allocate from the main heap and adjust the buffer to be
accessed from I-Bus. I didn't do this for ESP32-S2 because the port is new. I
want to wait until we have more into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
