xiaoxiang781216 commented on pull request #4028: URL: https://github.com/apache/incubator-nuttx/pull/4028#issuecomment-873003321
> @xiaoxiang781216 > > > This patch only address the mess issue in case 1. The lock ensure that the caller of syslog_write don't interlace with each other. > > Don't forget that also buffering needs fixing. In case of overflow it will split the message in multiple `syslog_write` calls, which again leaves room for this bug to appear.... Yes, it can't fix too, we need reserve at least one line buffer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
