xiaoxiang781216 commented on a change in pull request #4016:
URL: https://github.com/apache/incubator-nuttx/pull/4016#discussion_r663083983
##########
File path: sched/init/nx_start.c
##########
@@ -789,17 +789,35 @@ void nx_start(void)
sinfo("CPU0: Beginning Idle Loop\n");
for (; ; )
{
- /* Check heap & stack in idle thread */
+#if defined(CONFIG_STACK_COLORATION) && CONFIG_STACK_USAGE_SAFE_PERCENT > 0
- kmm_checkcorruption();
+ /* Check stack in idle thread */
-#if defined(CONFIG_STACK_COLORATION) && defined(CONFIG_DEBUG_MM)
- for (i = 0; i < CONFIG_MAX_TASKS && g_pidhash[i].tcb; i++)
+ for (i = 0; i < CONFIG_MAX_TASKS; i++)
{
- assert(up_check_tcbstack_remain(g_pidhash[i].tcb) > 0);
+ FAR struct tcb_s *tcb;
+ irqstate_t flags;
+
+ flags = enter_critical_section();
Review comment:
There are two check:
1. heap check which is guarded by CONFIG_MM_DEBUG
2. stack check which isn't guarded by DEBUG, but by a new option
STACK_USAGE_SAFE_PERCENT, it's redundant to let user select both DEBUG and
STACK_USAGE_SAFE_PERCENT to turn on this feature. user can disable the check by
set STACK_USAGE_SAFE_PERCENT=0(the default value)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
