yamt commented on a change in pull request #4014:
URL: https://github.com/apache/incubator-nuttx/pull/4014#discussion_r663620530
##########
File path: net/tcp/tcp_monitor.c
##########
@@ -346,15 +346,13 @@ void tcp_close_monitor(FAR struct socket *psock)
/* Find and free the the connection event callback */
net_lock();
- for (cb = conn->connevents;
- cb != NULL && cb->priv != (FAR void *)psock;
- cb = cb->nxtconn)
- {
- }
- if (cb != NULL)
+ for (cb = conn->connevents; cb != NULL; cb = cb->nxtconn)
{
- devif_conn_callback_free(conn->dev, cb, &conn->connevents);
+ if (cb->priv == (FAR void *)psock)
+ {
+ devif_conn_callback_free(conn->dev, cb, &conn->connevents);
Review comment:
i read the summary as of today but it doesn't seem answering my concern
about list corruption.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
