jerry-tang-realsil commented on pull request #4076: URL: https://github.com/apache/incubator-nuttx/pull/4076#issuecomment-877182153
Yeah, some code is from xiaomi. But xiaomi has told us that license just refer to others, such as esp32. And not all of the code added xiaomi's license. So I modified it but made a mistake that I added an extra wrong license. It's because I misunderstand the requirement of license. 发自我的iPhone 在 2021年7月9日，下午8:07，Alan Carvalho de Assis ***@***.***> 写道： First, Realtek has ever signed Apache License, so we still need to submit relative documents? Then, these code's license was added by mistake. It need not add realtek licnese actually. Above all, I don't think there is need to discuss the problem of license. @justinmclean<https://github.com/justinmclean> what do you think in this case? jerry-tang-realsil submitted a code as GPL, then he said it was a mistake, now he says Realtek already has signed a SGA with Apache (I suppose for other project) and he thinks we don't need to discuss the problem of the license. The issue is not the license "per se", but the fact he brought existent code that seams to come from other project and/or company (including code from Xiaomi that he removed the Copyright). I don't see someone in the future saying we are stealing code from other project and adding on NuttX. So, do you think we can ignore these facts and just let it in? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-nuttx/pull/4076#issuecomment-877138682>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AP2FFPASXGGZBGFXEGKJHDTTW3Q7LANCNFSM473V3NFA>. ------Please consider the environment before printing this e-mail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
