[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4120: net/tcp: tcp_sendfile need restore the file location at the end

[GitBox]

xiaoxiang781216 commented on a change in pull request #4120:
URL: https://github.com/apache/incubator-nuttx/pull/4120#discussion_r667588226



##########
File path: net/tcp/tcp_sendfile.c
##########
@@ -304,15 +303,6 @@ static uint16_t sendfile_eventhandler(FAR struct 
net_driver_s *dev,
            * happen until the polling cycle completes).
            */
 
-          ret = file_seek(pstate->snd_file,
-                          pstate->snd_foffset + pstate->snd_sent, SEEK_SET);
-          if (ret < 0)
-            {
-              nerr("ERROR: Failed to lseek: %d\n", ret);
-              pstate->snd_sent = ret;
-              goto end_wait;
-            }
-

Review comment:
       Yes, you are right. Please review the new version again.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org