xiaoxiang781216 commented on a change in pull request #4130:
URL: https://github.com/apache/incubator-nuttx/pull/4130#discussion_r667920852
##########
File path: include/sys/poll.h
##########
@@ -74,6 +74,7 @@
#define POLLERR (0x08)
#define POLLHUP (0x10)
+#define POLLRDHUP (0x10)
Review comment:
since shutdown isn't implemented in NuttX yet:
https://github.com/apache/incubator-nuttx/blob/master/libs/libc/net/lib_shutdown.c
from this discussion, it's a right defintion, otherwise the poller will lose
the notification:
https://stackoverflow.com/questions/56177060/pollhup-vs-pollrdhup
##########
File path: include/sys/poll.h
##########
@@ -74,6 +74,7 @@
#define POLLERR (0x08)
#define POLLHUP (0x10)
+#define POLLRDHUP (0x10)
Review comment:
This style follow POLLRDNORM/POLLRDBAND and POLLWRNORM/POLLWRBAND, so I
will keep 0x10 but add a comment.
##########
File path: include/sys/poll.h
##########
@@ -74,6 +74,7 @@
#define POLLERR (0x08)
#define POLLHUP (0x10)
+#define POLLRDHUP (0x10)
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
