KazuyaHioki commented on a change in pull request #4144:
URL: https://github.com/apache/incubator-nuttx/pull/4144#discussion_r669170145
##########
File path: tools/version.sh
##########
@@ -71,12 +71,12 @@ done
OUTFILE=$1
if [ -z ${VERSION} ] ; then
- VERSION=`git -C ${WD} describe 2>/dev/null | tail -1 | cut -d'-' -f2`
+ VERSION=`git -C ${WD} describe --match "nuttx-*" 2>/dev/null | tail -1 | cut
-d'-' -f2`
Review comment:
Yes. My understanding is that the 1st check of `git describe` is mainly
for release branches and 2nd check of `git tag` is for the master or other
branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
