xiaoxiang781216 commented on a change in pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#discussion_r677446091
##########
File path: include/nuttx/board.h
##########
@@ -331,6 +331,28 @@ int board_uniquekey(FAR uint8_t *uniquekey);
int board_switch_boot(FAR const char *system);
#endif
+/****************************************************************************
+ * Name: board_load_appimage
+ *
+ * Description:
+ * Load an application image from a given load address and perform the
+ * required actions for executing it (e.g. loading the Program Counter
+ * register with the application image entry point address).
+ *
+ * Input Parameters:
+ * loadaddr - Load address of the application image
+ *
+ * Returned Value:
+ * If this function returns, then it was not possible to load the
+ * application image due to some constraints. The return value in this case
+ * is a board-specific reason for the failure.
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_BOARDCTL_LOAD_APPIMAGE
+int board_load_appimage(uintptr_t loadaddr);
Review comment:
Ok, understand. Here is my suggestion:
1. LOAD_APPIMAGE to LAUNCH_IMAGE or EXECUTE_IMAGE since it not only load but
also execute image, and the image isn't an applicaiton but OS self.
2. It's better to change "uintptr_t loadaddr" to "FAR const char *image" or
"FAR void *image". The address is too related to XIP, I could like to see the
possibility to identify the image through the name not the address since the
name match the file system more natually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
