a-lunev commented on a change in pull request #4236:
URL: https://github.com/apache/incubator-nuttx/pull/4236#discussion_r677733304



##########
File path: boards/arm/stm32/emw3162/scripts/ld.script
##########
@@ -45,11 +45,16 @@ SECTIONS
         *(.fixup)
         *(.gnu.warning)
 
-        . = ALIGN(0x4);
+        /* SDIO_RXDMA32_CONFIG and SDIO_TXDMA32_CONFIG values in stm32_sdio.c
+         * give the DMA burst length of 16 bytes
+         * (DMA_SCR_MSIZE_32BITS x DMA_SCR_MBURST_INCR4).
+         * Thus the following alignment should be 0x10.
+         */
+        . = ALIGN(0x10);
         wlan_firmware_image_location = .;
         *(.wlan_firmware_image .wlan_firmware_image.*)
         wlan_firmware_image_end = .;
-        . = ALIGN(0x4);
+        . = ALIGN(0x10);

Review comment:
       Concerning firmware images, now I've removed ALIGN from the linker 
scripts, and added "aligned_data" to stm32_wlan_firmware.c instead.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to