gustavonihei commented on a change in pull request #4248:
URL: https://github.com/apache/incubator-nuttx/pull/4248#discussion_r679937285
##########
File path: arch/arm/src/cxd56xx/cxd56_sfc.c
##########
@@ -200,6 +200,7 @@ static int cxd56_ioctl(FAR struct mtd_dev_s *dev, int cmd,
unsigned long arg)
geo->blocksize = PAGE_SIZE;
geo->erasesize = SECTOR_SIZE;
geo->neraseblocks = priv->density >> SECTOR_SHIFT;
+ geo->firstblock = 0;
Review comment:
I've updated the PR with my interpretation from recent suggestions. This
could be extended for block devices and file systems as well via
`BIOC_PARTINFO`/`FIOC_PARTINFO` commands to be handled by each driver.
##########
File path: arch/arm/src/cxd56xx/cxd56_sfc.c
##########
@@ -200,6 +200,7 @@ static int cxd56_ioctl(FAR struct mtd_dev_s *dev, int cmd,
unsigned long arg)
geo->blocksize = PAGE_SIZE;
geo->erasesize = SECTOR_SIZE;
geo->neraseblocks = priv->density >> SECTOR_SHIFT;
+ geo->firstblock = 0;
Review comment:
I've updated the PR with my interpretation from recent suggestions. This
could be extended for block devices and file systems as well via
`BIOC_PARTINFO`/`FIOC_PARTINFO` commands to be handled by each implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
