gustavonihei commented on a change in pull request #4248:
URL: https://github.com/apache/incubator-nuttx/pull/4248#discussion_r680089452
##########
File path: drivers/mtd/mtd_partition.c
##########
@@ -413,6 +413,25 @@ static int part_ioctl(FAR struct mtd_dev_s *dev, int cmd,
unsigned long arg)
}
break;
+ case MTDIOC_PARTINFO:
+ {
+ FAR struct partition_info_s *info =
+ (FAR struct partition_info_s *)arg;
+ if (info != NULL)
+ {
+ info->magic = 0;
+ info->numsectors = priv->neraseblocks * priv->blkpererase;
+ info->length = info->numsectors * priv->blocksize;
+ info->sectorsize = priv->blocksize;
+ info->startsector = priv->firstblock;
+ info->endsector = priv->firstblock + info->numsectors;
+ info->parent = priv->parent->name;
+
+ ret = OK;
+ }
+ }
+ break;
+
Review comment:
> It seems like a VERY odd technical decision to duplicate an existing
interface purely to satisfy your personal preference. Redundancy like that
should not be tolerated in an OS and has never been tolerated in the past.
It's sad to hear that you believe I am bringing personal motivations to this
PR. My original intent was to just provide one single piece of data to the
application (the `firstblock` info from MTD partition), and I am dedicating my
time to work with you after each round of discussions, with the sole purpose of
trying to do what's best to the project.
So, please, I'd ask you to be a bit more reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
