gustavonihei edited a comment on pull request #4289: URL: https://github.com/apache/incubator-nuttx/pull/4289#issuecomment-893696996
> > Hi @phfbertoleti, try to squeeze the commit message into the 72 character limit from GitHub. Short commit messages also contribute to make `git log` cleaner. > > Also, I suggest that you that a look at the commit history, the contributors usually follow the template `<subsystem>: <commit message>`. > > Another personal suggestion not directly related to any NuttX standard: [this article](https://chris.beams.io/posts/git-commit/) from Chris Beams proposes 7 rules for writing good commit messages. It's worth checking out. > > @gustavonihei, thanks for the suggestion. I just have fixed it. Please, could you check if this is fine? The new message looks better, but now your branch contains duplicated commits. Commits 40c58427de2820995f404f58ecde9397d5017a3b and 75b0b3e96943716b27e1e4b7685b10ee36ac9ba3 should be removed. You may do this with `git rebase -i master` and drop them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
