xiaoxiang781216 edited a comment on pull request #4279: URL: https://github.com/apache/incubator-nuttx/pull/4279#issuecomment-902382783
> @anchao > > Testing was only done on armv8-m but your changing all the arch's. > > Did you verify the changes on all the archs in some fashion? > @davids5 the assembler version for armv7-m and armv8-m is same, so it's enough to test the c version on armv8-m. The c version should work for armv6-m too, but we don't have armv6-m device, so if you insist, we can keep armv6-m as it. > Like are the bins identical in size and order of operations the same? This PR https://github.com/apache/incubator-nuttx/pull/4317 should address your concern. This simple patch stuck for more than two weeks, if you don't have more concern, I will merge it by the weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
