gustavonihei commented on a change in pull request #4417:
URL: https://github.com/apache/incubator-nuttx/pull/4417#discussion_r696598550
##########
File path: arch/xtensa/include/esp32/irq.h
##########
@@ -409,6 +424,24 @@
* Inline functions
****************************************************************************/
+#ifdef CONFIG_ESP32_GPIO_IRQ
+#ifdef CONFIG_SMP
+static inline esp32_irq_gpio(int cpu)
Review comment:
```suggestion
static inline int esp32_irq_gpio(int cpu)
```
Missing return type.
Acceptable in C90, but forbidden from C99 onwards.
##########
File path: arch/xtensa/include/esp32/irq.h
##########
@@ -409,6 +424,24 @@
* Inline functions
****************************************************************************/
+#ifdef CONFIG_ESP32_GPIO_IRQ
+#ifdef CONFIG_SMP
+static inline esp32_irq_gpio(int cpu)
+{
+ if (cpu == 0)
+ {
+ return ESP32_IRQ_CPU_GPIO;
+ }
+ else
+ {
+ return ESP32_IRQ_APPCPU_GPIO;
Review comment:
```suggestion
return ESP32_IRQ_APPCPU_GPIO;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
