gustavonihei commented on a change in pull request #4504:
URL: https://github.com/apache/incubator-nuttx/pull/4504#discussion_r705393291
##########
File path: include/nuttx/video/fb.h
##########
@@ -569,6 +583,24 @@ struct fb_vtable_s
FAR const struct fb_overlayblend_s *blend);
# endif
#endif
+
+ /* Specific Controls ******************************************************/
+
+ /* Set the frequency of the framebuffer update panel (0: disable refresh) */
+
+ int (*setframerate)(FAR struct fb_vtable_s *vtable, int rate);
+
+ /* Get the frequency of the framebuffer update panel (0: disable refresh) */
+
+ int (*getframerate)(FAR struct fb_vtable_s *vtable);
+
+ /* Get the panel power status (0: full off). */
+
+ int (*getpower)(FAR struct fb_vtable_s *vtable);
+
+ /* Enable/disable panel power (0: full off). */
+
+ int (*setpower)(FAR struct fb_vtable_s *vtable, int power);
Review comment:
I believe the expected method for powering off the display device
according to the Framebuffer API is through `fb_uninitialize`, but nobody is
currently calling it.
https://github.com/apache/incubator-nuttx/blob/60b2a0e2a03878198db24a451bfe115a7d5e0e54/include/nuttx/video/fb.h#L638-L653
What about renaming the `FBIO[GET/SET]_POWER` IOCTL commands for something
like `FBIO_[INIT/DEINIT]`? Then the implementation for these commands would
rely on the `up_fbinitialize`/`up_fbuninitialize` APIs. Would this work out
right?
As for the framerate configuration, it also seems weird to me, but I don't
have the required background for suggesting anything different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
