[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4543: esp32: Use device specific lock as much as possible.

[GitBox]

saramonteiro commented on a change in pull request #4543:
URL: https://github.com/apache/incubator-nuttx/pull/4543#discussion_r708454727



##########
File path: arch/xtensa/src/esp32/esp32_rt_timer.c
##########
@@ -216,24 +219,22 @@ static void stop_rt_timer(FAR struct rt_timer_s *timer)
 
       if (ishead)
         {
-          if (!list_is_empty(&s_runlist))
+          if (!list_is_empty(&priv->runlist))
             {
               /* Set the value from the next timer as the new hardware timer
                * alarm value
                */
 
-              next_timer = container_of(s_runlist.next,
+              next_timer = container_of(priv->runlist.next,
                                         struct rt_timer_s,
                                         list);
               alarm = next_timer->alarm;
 
-              ESP32_TIM_SETALRVL(tim, alarm);
-              ESP32_TIM_SETALRM(tim, true);
+              ESP32_TIM_SETALRVL(priv->timer, alarm);
+              ESP32_TIM_SETALRM(priv->timer, true);
             }
         }
     }
-
-  leave_critical_section(flags);

Review comment:
       Ok, I just saw in the end of the file you're externally protecting it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org