michallenc commented on a change in pull request #4506:
URL: https://github.com/apache/incubator-nuttx/pull/4506#discussion_r709894470



##########
File path: drivers/lcd/Kconfig
##########
@@ -619,15 +625,15 @@ if LCD_ST7789
                ---help---
                        Specifies the Y offset of the LCD.
 
-       config LCD_ST7789_BPP
+       config LCD_ST77XX_BPP

Review comment:
       > @michallenc maybe you can define the CONFIG_LCD_ST77XX as main option 
and after enabling it the user can select (using choice) his model as ST7735 or 
ST7789
   
   Hi @acassis, sorry for the late reply. I´ve already started with those 
changes you proposed, haven´t pushed them to GIT yet. It still does not solve 
the problem that it would not allow the user to use both ST7735 and ST7789 (or 
the driver mentiopned by @PeterBee97 below) drivers together (although I don´t 
think more than one display is usually used by the user, so it might not be 
such a problem).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to