xiaoxiang781216 commented on a change in pull request #4615: URL: https://github.com/apache/incubator-nuttx/pull/4615#discussion_r716377689
########## File path: sched/signal/sig_default.c ########## @@ -194,11 +194,20 @@ static void nxsig_abnormal_termination(int signo) { FAR struct tcb_s *rtcb = (FAR struct tcb_s *)this_task(); - /* Notify the target if the non-cancelable or deferred cancellation set */ +#ifdef CONFIG_CANCELLATION_POINTS Review comment: Should we skip the cancellation point check here? It doesn't make sense that the default handle do the check, but user installed handler doesn't. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org