Ouss4 commented on a change in pull request #4698:
URL: https://github.com/apache/incubator-nuttx/pull/4698#discussion_r732100553



##########
File path: fs/mqueue/mq_open.c
##########
@@ -289,10 +289,9 @@ static int file_mq_vopen(FAR struct file *mq, FAR const 
char *mq_name,
        * be created with a reference count of zero.
        */
 
-      msgq = (FAR struct mqueue_inode_s *)nxmq_alloc_msgq(attr);
-      if (!msgq)
+      ret = nxmq_alloc_msgq(attr, &msgq);
+      if (ret < 0)
         {
-          ret = -ENOSPC;

Review comment:
       The return value has changed, was that intentional?  
   Standards specifies that `ENOSPC` will be returned in case we have 
insufficient space, now we seem to return `ENOMEM`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to