gustavonihei commented on a change in pull request #4699:
URL: https://github.com/apache/incubator-nuttx/pull/4699#discussion_r732191159
##########
File path: include/nuttx/cache.h
##########
@@ -303,6 +367,71 @@ void up_flush_dcache_all(void);
# define up_flush_dcache_all()
#endif
+/****************************************************************************
+ * Name: up_lock_dcache
+ *
+ * Description:
+ * Prefetch and lock the data cache within the specified region.
+ * If the specified address is not present in the data cache,
+ * Some archs transfer the line from memory, other archs wait the
Review comment:
```suggestion
* some architectures transfer the line from memory, others wait the
```
##########
File path: include/nuttx/cache.h
##########
@@ -303,6 +367,71 @@ void up_flush_dcache_all(void);
# define up_flush_dcache_all()
#endif
+/****************************************************************************
+ * Name: up_lock_dcache
+ *
+ * Description:
+ * Prefetch and lock the data cache within the specified region.
+ * If the specified address is not present in the data cache,
+ * Some archs transfer the line from memory, other archs wait the
+ * address be read from memory, and then lock.
+ *
+ * Input Parameters:
+ * start - virtual start address of region
+ * end - virtual end address of region + 1
+ *
+ * Returned Value:
+ * None
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_ARCH_DCACHE_LOCK
+void up_lock_dcache(uintptr_t start, uint32_t end);
+#else
+# define up_lock_dcache()
+#endif
+
+/****************************************************************************
+ * Name: up_unlock_dcache
+ *
+ * Description:
+ * Unlock the data cache within the specified region.
+ *
+ * Input Parameters:
+ * start - virtual start address of region
+ * end - virtual end address of region + 1
+ *
+ * Returned Value:
+ * None
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_ARCH_DCACHE_LOCK
+void up_unlock_dcache(uintptr_t start, uint32_t end);
+#else
+# define up_unlock_dcache()
+#endif
+
+/****************************************************************************
+ * Name: up_unlock_dcache_all
+ *
+ * Description:
+ * Unlock the entire contents of D cache.
Review comment:
```suggestion
* Unlock the entire contents of data cache.
```
##########
File path: include/nuttx/cache.h
##########
@@ -303,6 +367,71 @@ void up_flush_dcache_all(void);
# define up_flush_dcache_all()
#endif
+/****************************************************************************
+ * Name: up_lock_dcache
+ *
+ * Description:
+ * Prefetch and lock the data cache within the specified region.
+ * If the specified address is not present in the data cache,
+ * Some archs transfer the line from memory, other archs wait the
+ * address be read from memory, and then lock.
+ *
+ * Input Parameters:
+ * start - virtual start address of region
+ * end - virtual end address of region + 1
+ *
+ * Returned Value:
+ * None
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_ARCH_DCACHE_LOCK
+void up_lock_dcache(uintptr_t start, uint32_t end);
+#else
+# define up_lock_dcache()
+#endif
+
+/****************************************************************************
+ * Name: up_unlock_dcache
+ *
+ * Description:
+ * Unlock the data cache within the specified region.
+ *
+ * Input Parameters:
+ * start - virtual start address of region
+ * end - virtual end address of region + 1
+ *
+ * Returned Value:
+ * None
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_ARCH_DCACHE_LOCK
+void up_unlock_dcache(uintptr_t start, uint32_t end);
Review comment:
```suggestion
void up_unlock_dcache(uintptr_t start, uintptr_t end);
```
##########
File path: include/nuttx/cache.h
##########
@@ -303,6 +367,71 @@ void up_flush_dcache_all(void);
# define up_flush_dcache_all()
#endif
+/****************************************************************************
+ * Name: up_lock_dcache
+ *
+ * Description:
+ * Prefetch and lock the data cache within the specified region.
+ * If the specified address is not present in the data cache,
+ * Some archs transfer the line from memory, other archs wait the
+ * address be read from memory, and then lock.
+ *
+ * Input Parameters:
+ * start - virtual start address of region
+ * end - virtual end address of region + 1
+ *
+ * Returned Value:
+ * None
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_ARCH_DCACHE_LOCK
+void up_lock_dcache(uintptr_t start, uint32_t end);
Review comment:
```suggestion
void up_lock_dcache(uintptr_t start, uintptr_t end);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
