gustavonihei opened a new pull request #4718:
URL: https://github.com/apache/incubator-nuttx/pull/4718


   ## Summary
   This PR intends to fix an error handling logic of `nx_mount`.
   
   Instead of reporting the failure to find a given FS, `nx_mount` was 
reporting a failure to find the block driver, even when the actual block driver 
exists.
   
   **Before:**
   ```
   find_blockdriver: pathname="/dev/esp32flash"
   find_blockdriver: /dev/esp32flash is a MTD
   nx_mount: ERROR: Failed to find block driver /dev/esp32flash
   setup_littlefs: ERROR: Failed to mount the FS volume: -15
   init_storage_partition: ERROR: Failed to setup littlefs
   ERROR: Failed to initialize SPI Flash
   ```
   
   **After:**
   ```
   find_blockdriver: pathname="/dev/esp32flash"
   find_blockdriver: /dev/esp32flash is a MTD
   nx_mount: ERROR: Failed to find MTD based file system littlefs
   setup_littlefs: ERROR: Failed to mount the FS volume: -19
   init_storage_partition: ERROR: Failed to setup littlefs
   ERROR: Failed to initialize SPI Flash
   ```
   
   ## Impact
   `nx_mount` will now return a different (but correct) error code for missing 
file system support.
   
   ## Testing
   `esp32-devkitc:spiflash` attempting to mount `littlefs` when 
`CONFIG_FS_LITTLEFS` is not selected.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to