jlaitine commented on pull request #4779: URL: https://github.com/apache/incubator-nuttx/pull/4779#issuecomment-961629697
> The only issue with moving these functions into libc is that it modifies the OS interface definition and violates the portable POSIX interface. > > We normally keep non-standard helper functions like under apps/ so avoid contaminating the OS interface.with non-standard functions. > > I think the fact that they are prototyped in nuttx/c;lock.h does at least make their non-standard nature clearer (but doesn't help with portability). Thanks for your advice! I am of course willing to re-work this if you can advice how to nicely implement the change in libs/libc/wqueue/work_usrthread.c One obvious way is of course to duplicate the tick->timespec calculations locally in there (where I actually started at...). I was trying to avoid doing that, since it turns out to be a bit more complex than I first thought, considering all the different platforms, supported data-types etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
