[GitHub] [incubator-nuttx] gustavonihei commented on pull request #4811: procfs: fix ps can't log out Group id

[GitBox]

gustavonihei commented on pull request #4811:
URL: https://github.com/apache/incubator-nuttx/pull/4811#issuecomment-964238662


   Thanks for the clarification, I think I understand now.
   But can't we call to `procfs_snprintf` using the same conditions from 
`nshlib/nsh_proccmds.c`?
   I mean, why remove the option for outputting the PPID?
   Something like this:
   ```patch
   --- a/fs/procfs/fs_procfsproc.c
   +++ b/fs/procfs/fs_procfsproc.c
   @@ -497,9 +497,18 @@ static ssize_t proc_status(FAR struct proc_file_s 
*procfile,
      group = tcb->group;
      DEBUGASSERT(group != NULL);
    
   +#ifdef CONFIG_SCHED_HAVE_PARENT
   +#ifdef HAVE_GROUPID
   +  linesize   = procfs_snprintf(procfile->line, STATUS_LINELEN,
   +                               "%-12s%d\n",
   +                               "Group:", group->tg_pid);
   +#else
      linesize   = procfs_snprintf(procfile->line, STATUS_LINELEN,
                                   "%-12s%d\n", "PPID:",
                                   group->tg_ppid);
   +#endif
   +#endif
   +
      copysize   = procfs_memcpy(procfile->line, linesize, buffer, remaining,
                                 &offset);
    
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org