davids5 commented on a change in pull request #4894:
URL: https://github.com/apache/incubator-nuttx/pull/4894#discussion_r757786774
##########
File path: libs/libc/misc/Make.defs
##########
@@ -22,6 +22,7 @@
CSRCS += lib_umask.c lib_utsname.c
CSRCS += lib_xorshift128.c lib_tea_encrypt.c lib_tea_decrypt.c
+CSRCS += lib_err.c
Review comment:
My concern is not about unused function. It is about duplication of
symbol names
```
err
verr
errx
verrx
```
used in NuttX based system before this PR that have different semantics.
If a user of NuttX uses **their** this will cause link failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
