LingaoM commented on pull request #4925: URL: https://github.com/apache/incubator-nuttx/pull/4925#issuecomment-984216673
> > > For consistency with other shell script files, the name should probably be changed to size_report.sh > > > > > > `.sh` mean bash script not for python. > > Oops.. right. Other python scripts end with .py. So same comment, but using the .py extension. Actually, I just want to be consistent with the original(https://github.com/zephyrproject-rtos/zephyr/blob/main/scripts/footprint/size_report), or do we need to rename it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
