xiaoxiang781216 commented on a change in pull request #4994:
URL: https://github.com/apache/incubator-nuttx/pull/4994#discussion_r768289142



##########
File path: libs/libc/locale/lib_gettext.c
##########
@@ -76,7 +76,7 @@ static FAR const char *g_catname[] =
 static sem_t g_sem = SEM_INITIALIZER(1);
 static FAR struct mofile_s *g_mofile;
 
-#ifdef CONFIG_BUILD_KERNEL
+#if defined(CONFIG_BUILD_KERNEL) || !defined(CONFIG_LIBC_LOCALE)

Review comment:
       @pkarashchenko it doesn't make sense to check CONFIG_LIBC_LOCALE since 
lib_gettext.c already bypass in Make.defs:
   
https://github.com/apache/incubator-nuttx/blob/master/libs/libc/locale/Make.defs#L21




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to