pkarashchenko commented on a change in pull request #4999:
URL: https://github.com/apache/incubator-nuttx/pull/4999#discussion_r769387932
##########
File path: include/nuttx/sched_note.h
##########
@@ -336,7 +345,7 @@ struct note_string_s
struct note_binary_s
{
struct note_common_s nbi_cmn; /* Common note parameters */
- uint32_t nbi_module; /* Module number */
+ uint8_t nbi_module[4]; /* Module number */
Review comment:
Yes, but there is not benefit of doing it. Both `void
sched_note_dump(uint32_t module, uint8_t event, FAR const void *buf, size_t
len)` and `void sched_note_vbprintf(uint32_t module, uint8_t event, FAR const
char *fmt, va_list va)` take `uint32_t module` as a parameter and it is
naturally to store it into a same type placeholder. Even `NOTE_MODULE` macro
creates an integer value. So why do we need this particular change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
