Ouss4 commented on a change in pull request #5008:
URL: https://github.com/apache/incubator-nuttx/pull/5008#discussion_r770415082
##########
File path: arch/xtensa/src/common/xtensa_dumpstate.c
##########
@@ -96,10 +96,10 @@ static inline void up_showtasks(void)
#endif
/****************************************************************************
- * Name: xtensa_stackdump
+ * Name: up_stackdump
****************************************************************************/
-static void xtensa_stackdump(uint32_t sp, uint32_t stack_top)
+static void up_stackdump(uint32_t sp, uint32_t stack_top)
Review comment:
This is an internal function, the naming convention for these functions
is `arch_function`. The `up_` prefix is reserved for functions exported
outside the arch directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
