gustavonihei commented on a change in pull request #929:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/929#discussion_r772687373
##########
File path: examples/mcuboot/ota/Kconfig
##########
@@ -0,0 +1,56 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+menuconfig EXAMPLES_MCUBOOT_OTA
Review comment:
Sorry, I missed one point that you commented earlier which is important
to the discussion:
> The suffix APP_AGENT + APP_CONFIRM are enough to represent each
application inside this demo.
Although this demo you are proposing includes both example applications, I
believe there is no need to reflect it in the folder structure or in the
kconfig hierarchy. The demo is best characterized by the set of options
included in the `defconfig` file.
So all the MCUboot example application should appear on the level at
`examples/mcuboot`.
##########
File path: examples/mcuboot/ota/Kconfig
##########
@@ -0,0 +1,56 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+menuconfig EXAMPLES_MCUBOOT_OTA
Review comment:
Sorry, I missed one point that you commented earlier which is important
to the discussion:
> The suffix APP_AGENT + APP_CONFIRM are enough to represent each
application inside this demo.
Although this demo you are proposing includes both example applications, I
believe there is no need to reflect it in the folder structure or in the
kconfig hierarchy. The demo is best characterized by the set of options
included in the `defconfig` file.
So all the MCUboot example applications should appear on the level at
`examples/mcuboot`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
