gustavonihei commented on a change in pull request #5057:
URL: https://github.com/apache/incubator-nuttx/pull/5057#discussion_r773761779



##########
File path: arch/xtensa/src/common/xtensa_dumpstate.c
##########
@@ -53,47 +53,165 @@ static uint32_t s_last_regs[XCPTCONTEXT_REGS];
  ****************************************************************************/
 
 /****************************************************************************
- * Name: up_taskdump
+ * Name: xtensa_dump_stak
  ****************************************************************************/
 
-#ifdef CONFIG_STACK_COLORATION
-static void up_taskdump(struct tcb_s *tcb, void *arg)
+static void xtensa_dump_stak(FAR struct tcb_s *tcb, FAR void *arg)

Review comment:
       ```suggestion
   static void xtensa_dump_task(struct tcb_s *tcb, void *arg)
   ```
   Typo and we may omit `FAR` in arch specific code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to