gustavonihei commented on a change in pull request #5056:
URL: https://github.com/apache/incubator-nuttx/pull/5056#discussion_r774739194
##########
File path: arch/xtensa/src/esp32/esp32_wifi_adapter.c
##########
@@ -1165,6 +1188,70 @@ static int32_t esp_semphr_give(void *semphr)
return osi_errno_trans(ret);
}
+/****************************************************************************
+ * Name: esp_semphr_take_from_isr
+ *
+ * Description:
+ * Try to take semaphore from within an interrupt service routine.
+ *
+ * Input Parameters:
+ * semphr - Semaphore data pointer
+ *
+ * Returned Value:
+ * True if success or false if fail
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_ESP32_WIFI_BT_COEXIST
Review comment:
```suggestion
#ifdef CONFIG_ESP32_WIFI_BT_COEXIST
/****************************************************************************
* Name: esp_semphr_take_from_isr
*
* Description:
* Try to take semaphore from within an interrupt service routine.
*
* Input Parameters:
* semphr - Semaphore data pointer
*
* Returned Value:
* True if success or false if fail
*
****************************************************************************/
```
Since this `ifdef` wraps more than just a single function, it is better to
move it up so that the documentation for the first function is not left out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
