xiaoxiang781216 commented on a change in pull request #5070:
URL: https://github.com/apache/incubator-nuttx/pull/5070#discussion_r774948755
##########
File path: sched/semaphore/sem_holder.c
##########
@@ -947,7 +947,7 @@ void nxsem_add_holder_tcb(FAR struct tcb_s *htcb, FAR sem_t
*sem)
* inheritance is effectively disabled.
*/
- if ((sem->flags & PRIOINHERIT_FLAGS_DISABLE) == 0)
+ if ((sem->flags & PRIOINHERIT_FLAGS_ENABLE) == 1)
Review comment:
!= 0
##########
File path: libs/libc/semaphore/sem_getprotocol.c
##########
@@ -56,7 +56,7 @@ int sem_getprotocol(FAR sem_t *sem, FAR int *protocol)
DEBUGASSERT(sem != NULL && protocol != NULL);
#ifdef CONFIG_PRIORITY_INHERITANCE
- if ((sem->flags & PRIOINHERIT_FLAGS_DISABLE) != 0)
+ if ((sem->flags & PRIOINHERIT_FLAGS_ENABLE) == 0)
Review comment:
if ((sem->flags & PRIOINHERIT_FLAGS_ENABLE) != 0)
{
*protocol = SEM_PRIO_INHERIT;
}
else
{
*protocol = SEM_PRIO_NONE;
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
