pussuw opened a new pull request #946:
URL: https://github.com/apache/incubator-nuttx-apps/pull/946


   ## Summary
   The import target for kernel build now fails, due to setting libapps.a
   as the default value for the BIN variable.
   
   The fail happens when the ELFLD function passes the LDLIBS parameter
   (which contains BIN / libapps.a) for the linker. There is no rule to
   create libapps.a in the case of the kernel build, so the linker gives
   an error due to it being missing.
   
   This commit patches this behavior so that BIN is not appended to
   LDLIBS. Another option would be to implement a dummy rule to create
   libapps.a, but looking at the git history this is no longer wanted
   behavior, thus the error is patched like this.
   
   ## Impact
   Should fix the ELFLD function / linkage when using CONFIG_BUILD_KERNEL
   
   ## Testing
   Tested that it builds. Created a ROMFS image with the .elf binaries. Did 
_not_ test that the elf files themselves work / contain a valid application 
(elfloader does work however).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to