normanr opened a new pull request #5107:
URL: https://github.com/apache/incubator-nuttx/pull/5107


   ## Summary
   commit e1c306f2dd3b8f4f304a77a908e965c05fb3eab2 added sethostname. The null 
terminator should be added after the new hostname (and only at the very end if 
the new hostname is the maximum length).
   
   ## Impact
   Without this if the hostname is set to `hello-world` and then it's set to 
`short`, the resulting hostname is incorrectly `short-world`.
   
   Also renamed the `size` argument to `namelen` to match gethostname and the 
blockcomment input parameter name.
   
   ## Testing
   Manually tested with medium and then short hostnames. Also tested with 
hostnames 31, 32, and 33 characters in length to check that they were truncated 
correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to