AlanRosenthal opened a new pull request #5147:
URL: https://github.com/apache/incubator-nuttx/pull/5147


   ## Summary
   `include/nuttx/version.h` is dependent on `.version`, which needs to run for 
every invocation of make, since git info can update at any time.
   Currently the `.version` target is PHONY, thus making 
`include/nuttx/version.h` and `context` targets (and every target that depends 
on `context`) have to run every time.
   
   ## Impact
   This PR modifies `.version` so it's a real rule. Additionally, 
`tools/version.sh` is run every invocation of make. This maintains the current 
behavior while preventing some targets from needlessly running every time
   
   ## Testing
   Verified `.version` changed appropriately when git's commit changed.
   Verified `include/nuttx/version.h` changed appropriately only when a new 
`.version` file was generated 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to