yamt commented on a change in pull request #4881:
URL: https://github.com/apache/incubator-nuttx/pull/4881#discussion_r778486542



##########
File path: drivers/video/vnc/vnc_keymap.c
##########
@@ -29,13 +29,8 @@
 #include <errno.h>
 
 #include <nuttx/ascii.h>
-
-#define XK_MISCELLANY 1 /* Select X11 character set */
-#define XK_LATIN1     1
-#define XK_XKB_KEYS   1
-
 #include <nuttx/video/vnc.h>
-#include <nuttx/input/x11_keysymdef.h>
+#include <nuttx/input/x11_keysym.h>

Review comment:
       is it intentional to enable more groups for vnc? if yes, can you mention 
it in the commit message?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to