AlanRosenthal opened a new pull request #5176:
URL: https://github.com/apache/incubator-nuttx/pull/5176


   ## Summary
   Previously the context rule and dirlinks rule were doing the same thing.
   * the `context` target called other `context` targets in subdirectories.
   * the `context` targets had `.dirlinks` as a prerequisite, which created 
symlinks
   * the `.dirlinks` target called other `.dirlinks` targets in subdirectories, 
which created symlinks
   
   Changes:
   * `.dirlinks` doesn't call other sub-`.dirlinks` targets. All `context` 
targets will take care of creating symlinks by having `.dirlinks` as 
prerequisites
   * There was logic in `tools/Config.mk` which was duplicated in 
`boards/Makefile`. This PR removes the duplicated logic
   * `apps_preconfig` was incorrectly depending on `.dirlinks`
   * All `Configuration targets` now run the in the following order, ensuring 
deterministic behavior: `clean-context`, `context`, `apps_preconfig` then 
`kconfig...`
   
   ## Impact
   This PR cleans up and isolates logic. It additionally makes the 
`Configuration targets` set more deterministic by running `clean-context` then 
`context`
   
   ## Testing
   Verified build locally, CI will verify all the builds
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to